engine: configure registry push/pull with containerd#24213
Open
dvdksn wants to merge 2 commits intodocker:mainfrom
Open
engine: configure registry push/pull with containerd#24213dvdksn wants to merge 2 commits intodocker:mainfrom
dvdksn wants to merge 2 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
disable-push-registry
branch
from
49a658a to
0ed696e
Compare
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
This is a well-written documentation page that clearly explains how to configure per-registry behavior using hosts.toml files with the containerd image store.
Strengths:
- Clear structure with progressive examples (disable push → mirror → internal-only)
- Proper front matter with all required fields
- Accurate technical content with correct file paths and TOML syntax
- Good use of tables for reference information
- Appropriate callout explaining security limitations
- Helpful section explaining interaction with daemon.json settings
- Links to related documentation are valid
No issues found. The page follows Docker's documentation style guide and provides users with the information they need to configure registry access.
dmcgowan
reviewed
Mar 19, 2026
dmcgowan
reviewed
Mar 20, 2026
dmcgowan
reviewed
Mar 20, 2026
dmcgowan
reviewed
Mar 20, 2026
dmcgowan
reviewed
Mar 20, 2026
dmcgowan
reviewed
Mar 20, 2026
Contributor
|
Sorry our docs can be a bit confusing and the use of it with "default" and "host" is a bit hard to follow. The idea was that the simple cases would just be updating defaults and possibly adding some mirrors. The amount of "features" that could be support via different permutations is part of the design, but not done in the easiest follow way. Parts of this are mentioned in https://github.com/containerd/containerd/blob/main/docs/hosts.md though. |
Address review feedback from dmcgowan: - Fix "disable push" example to use top-level capabilities field instead of a [host] entry (the [host] section is for mirrors, not the default endpoint) - Fix mirror example to remove redundant [host] entry for the upstream registry; server already handles fallback - Replace "internal registry only" example with a simpler correct approach: set server to the internal registry URL, no [host] entries needed - Add Windows directory name format for registries with ports - Add _default/ directory to the tree and explain its use as a global fallback - Clarify format section: top-level fields vs [host] sections, and that capabilities defaults to all three if not set Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
disable-push-registry
branch
from
b9466d6 to
c3c4f9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com